[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

David Edmondson dme at dme.org
Wed Dec 28 07:22:45 PST 2011


On Mon, 26 Dec 2011 10:49:46 +0000, David Edmondson <dme at dme.org> wrote:
> > > +     ((= start-of-message (point))
> > > +      ;; The cursor is at the start of the current message - move to
> > > +      ;; the previous open message.
> > > +      (notmuch-show-previous-open-message))
> > 
> > This will jump to the beginning of the previous message if I'm at the
> > beginning of a message.  I would expect rewind to show me the end of
> > the previous message in this case.
> 
> That would definitely more closely be the inverse of how advance works,
> but is it the most useful behaviour?

I thought about this a bit more (mostly because I don't want to write
tests for one behaviour and then have to change them - writing tests for
emacs with the current test suite is painful).

If you want to go back a page you can use M-v. The whole point of
binding DEL to something in `notmuch-show-mode' is that it implement
something other than the vanilla behaviour. Simply showing the previous
page (the equivalent of M-v) adds no value.

Hence, I'd like to keep the (jump back a full message) behaviour in the
patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111228/6aab5397/attachment.pgp>


More information about the notmuch mailing list