[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.
Daniel Kahn Gillmor
dkg at fifthhorseman.net
Tue Dec 27 06:27:52 PST 2011
On 12/23/2011 10:45 PM, Austin Clements wrote:
> Quoth Dmitry Kurochkin on Dec 10 at 3:25 am:
>> + /* For some reason the GMimeSignatureValidity returned
>> + * here is not a const (inconsistent with that
>> + * returned by
>> + * g_mime_multipart_encrypted_get_signature_validity,
>> + * and therefore needs to be properly disposed of.
>> + * Hopefully the API will become more consistent. */
>>
>> Ouch. In gmime 2.6 this API has changed, but looks like the
>> issue is still there. Is there a bug for it? If yes, we should
>> add a reference to the comment. Otherwise, we should file the
>> bug and then add a reference to the comment :)
>
> It looks like they're both non-const in 2.6 (which makes more sense to
> me). I updated the comment to mention this.
Here's the bug report where this was discussed with upstream, fwiw:
https://bugzilla.gnome.org/show_bug.cgi?id=640911
--dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1030 bytes
Desc: OpenPGP digital signature
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111227/7ce64994/attachment.pgp>
More information about the notmuch
mailing list