[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

[Jameson Graef Rollins]

On Mon, 26 Dec 2011 22:00:21 +0000, David Edmondson <dme at dme.org> wrote:
> Understood. For me this fell inside the 'trivial other change' boundary.

Fwiw, I don't remember there ever being such a distinction.  I think
we've always insisted that unrelated changes should be excluded.  As a
general rule, I think all patches should be as atomic as they can
possibly be.  I would much rather have more smaller, atomic patches than
fewer longer, composite ones.

> > And can you please explain why `when' is better than `if' here?  Then I
> > will know which one to use the next time :)
> 
> `if' allows only a single statement for `then', which results in code like:
> 
>      (if foo
>         (progn
>           (this)
>           (that)
>           (theother)))
> 
> so if there is no `else' clause I've been preferring:
> 
>       (when foo
>         (this)
>         (that)
>         (theother))
> 
> but that's obviously personal and not important in this specific case.

That's good.  I like it.  The if construction always annoyed me a bit
for this reason.  The when construction is definitely cleaner.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111226/374961f1/attachment-0001.pgp>