[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

[Dmitry Kurochkin]

On Tue, 13 Dec 2011 18:32:11 +0100, Thomas Jost <schnouki at schnouki.net> wrote:
> In 123,456.78, "." is the decimal separator, but "," is the thousands separator.
> 
> This commit also mentions the space being used as thousands separator in several
> European countries.
> ---

What do perople think about making the thousands separator a space by
default?

>  emacs/notmuch-hello.el |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 0582cae..0fe9c1d 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -131,10 +131,10 @@ So:
>  	  (integer :tag "Number of characters")
>  	  (float :tag "Fraction of window")))
>  
> -(defcustom notmuch-decimal-separator ","
> -  "The string used as a decimal separator.
> +(defcustom notmuch-thousands-separator ","
> +  "The string used as a thousands separator.

I suggest renaming this to notmuch-hello-thousands-separator.

Looks good otherwise.

Regards,
  Dmitry

>  
> -Typically \",\" in the US and UK and \".\" in Europe."
> +Typically \",\" in the US and UK and \".\" or \" \" in Europe."
>    :group 'notmuch
>    :type 'string)
>  
> @@ -159,7 +159,7 @@ Typically \",\" in the US and UK and \".\" in Europe."
>      (apply #'concat
>       (number-to-string (car result))
>       (mapcar (lambda (elem)
> -	      (format "%s%03d" notmuch-decimal-separator elem))
> +	      (format "%s%03d" notmuch-thousands-separator elem))
>  	     (cdr result)))))
>  
>  (defun notmuch-hello-trim (search)
> -- 
> 1.7.8
> 
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch