[PATCH 1/2] emacs: remove some code duplication in notmuch-show

Jameson Graef Rollins jrollins at finestructure.net
Mon Nov 28 06:24:19 PST 2011


On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> -(defun notmuch-show-get-header (header)
> +(defun notmuch-show-get-header (header &optional props)
>    "Return the named header of the current message, if any."
> -  (plist-get (notmuch-show-get-prop :headers) header))
> +  (plist-get (notmuch-show-get-prop :headers props) header))

Hey, Dmitry.  It looks like the new plist-get call is assuming props is
defined, but it looks like it's only optional in the argument list.
Wouldn't the function fail if the props argument is not supplied?

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111128/e72e6245/attachment.pgp>


More information about the notmuch mailing list