[PATCH 2/2] Fixed warnings for test/symbol-test.cc.

David Bremner david at tethera.net
Fri Nov 25 05:07:13 PST 2011


On Fri, 25 Nov 2011 11:54:52 +0100, Amadeusz Żołnowski <aidecoe at aidecoe.name> wrote:
> ---
> +  //notmuch_database_t *notmuch =
> +  notmuch_database_open ("fakedb", NOTMUCH_DATABASE_MODE_READ_ONLY);

Leaving commented out code in is for people without version control ;).

Shouldn't this cast to void?

>  
>    try{
> -    (void)new Xapian::WritableDatabase ("./nonexistant",					Xapian::DB_OPEN);
> +    (void)new Xapian::WritableDatabase ("./nonexistant", Xapian::DB_OPEN);

This seems to be whitespace only?  I'm not against whitespace cleanup,
but please put it in seperate commits. Or am I staring past a real
change here?

d



More information about the notmuch mailing list