[PATCH] dump: Don't sort.

Tomi Ollila tomi.ollila at iki.fi
Mon Nov 21 03:04:18 PST 2011


On Mon, 14 Nov 2011 21:10:44 -0400, David Bremner <david at tethera.net> wrote:
> On Sat, 29 Oct 2011 12:37:37 +0200, Thomas Schwinge <thomas at schwinge.name> wrote:
> > From: Thomas Schwinge <thomas at schwinge.name>
> > 
> > This improves usage experience considerably in the given scenario.
> > 
> 
> I'm not sure if I mentioned this only in IRC, so let me recap.
> 
> Personally, I think this needs more information in the commit message,
> and (optionally) less in the comment. I would prefer to be able to
> understand what is going on just from the output of git log.

I agree; the git commit message:

--8<----8<----8<----8<----8<----8<----8<----8<----8<--
dump: Don't sort.

This improves usage experience considerably in the given scenario.
--8<----8<----8<----8<----8<----8<----8<----8<----8<--

Is not very informative. Better to describe the given scenario in commit
message and (perhaps!) tune the comment in the code.

We've seen that the patch is very useful -- So, Thomas, please provide a 
patch in a format it can be comfortably added to the repository :).

> 
> d

Tomi


More information about the notmuch mailing list