[PATCH] emacs: Avoid unnecessary markers.
Dmitry Kurochkin
dmitry.kurochkin at gmail.com
Sun Nov 20 17:11:33 PST 2011
On Sun, 20 Nov 2011 20:07:02 -0500, Austin Clements <amdragon at MIT.EDU> wrote:
> This is just cleanup. These markers are all immediately resolved to
> points by Emacs, so using markers here is just unncessary overhead.
> ---
> I originally did this for performance, since Emacs has to scan all
> un-GC'd markers on every buffer change, but it turns out to matter
> notmuch.
>
Again, makes sense and looks good.
Regads,
Dmitry
> emacs/notmuch.el | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index a8e4d62..f15a75b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -805,12 +805,12 @@ non-authors is found, assume that all of the authors match."
> (goto-char (point-max))
> (if (/= (match-beginning 1) line)
> (insert (concat "Error: Unexpected output from notmuch search:\n" (substring string line (match-beginning 1)) "\n")))
> - (let ((beg (point-marker)))
> + (let ((beg (point)))
> (notmuch-search-show-result date count authors subject tags)
> - (notmuch-search-color-line beg (point-marker) tag-list)
> - (put-text-property beg (point-marker) 'notmuch-search-thread-id thread-id)
> - (put-text-property beg (point-marker) 'notmuch-search-authors authors)
> - (put-text-property beg (point-marker) 'notmuch-search-subject subject)
> + (notmuch-search-color-line beg (point) tag-list)
> + (put-text-property beg (point) 'notmuch-search-thread-id thread-id)
> + (put-text-property beg (point) 'notmuch-search-authors authors)
> + (put-text-property beg (point) 'notmuch-search-subject subject)
> (if (string= thread-id notmuch-search-target-thread)
> (progn
> (set 'found-target beg)
> --
> 1.7.7.2
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
More information about the notmuch
mailing list