[PATCH 0/6] Rebase of Pieter's "set test prereqs"
Pieter Praet
pieter at praet.org
Wed Nov 16 12:50:17 PST 2011
On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost <schnouki at schnouki.net> wrote:
> Hello list,
>
> This is another rebased version of Pieter's series to add GPG and Emacs as test
> prereqs, plus some additions on my own. (Rebased and posted as requested by
> Pieter [1].)
>
Thanks Thomas!
Although... you may have misread (or maybe I mistyped :), but what I
actually intended [1] was for you to rebase *only* your fixes on top of
my rebased series (e.g. see "tjost-fixes.patch" in att), so you could
receive proper credit for cleaning up my mess.
Also, while my apprehension [2,3] re the inclusion of the SCREEN/DTACH
prereq in patches #4,5,6 didn't have much merit (it's an all-or-nothing
affair anyways), the issue [3] in patch #5 @ "Reply within emacs" still
stands: `sed' will run unconditionally, and treat "EMACS" as an input
file. (see "sed-prereq-fix.patch" in att).
Thanks again!
> Changes as compared to Pieter's patches (including parts from [2]):
> - prereqs are not tested using test_expect_success as they were in Pieter's
> original patches, but using a new function called test_set_bin_prereq. I wrote
> this before the gdb prereq was added, hence the different way to set it.
>
> - some fixes in Pieter's patches so that it actually works when gpg is not
> installed. Can't exactly remember what (...but you can just check his original
> patches), but in the end it was working fine in a chroot without gpg.
>
> - since Emacs is now run using dtach, the emacs prereq also depends on dtach.
> The presence of emacs and dtach is also checked in the test_emacs() function
> of the test suite.
>
> - testing for prereqs is now done using the "hash" built-in instead of "which",
> as suggested in [3].
>
> Tested with and without dtach. A previous version of this series was also
> without emacs/gpg in a chroot, but not this one :)
>
> [1] id:"874ny4fcdz.fsf at praet.org"
> [2] id:"1317660447-27520-1-git-send-email-schnouki at schnouki.net"
> [3] id:"87zkgemodd.fsf at praet.org"
>
> Pieter Praet (4):
> test: add 'GnuPG' prereq to dependent 'crypto' tests
> test: add 'Emacs' prereq to dependent 'crypto' tests
> test: add 'Emacs' prereq to dependent 'emacs' tests
> test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer'
> tests
>
> Thomas Jost (2):
> test: define a helper function for defining prereqs on executables
> test: check if emacs and dtach are available in test_emacs()
>
> test/crypto | 46 +++++++++++++++-------
> test/emacs | 82 +++++++++++++++++++++------------------
> test/emacs-large-search-buffer | 9 +++-
> test/test-lib.sh | 17 ++++++++
> 4 files changed, 99 insertions(+), 55 deletions(-)
>
> --
> 1.7.7.3
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sed-prereq-fix.patch
Type: text/x-patch
Size: 541 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111116/69dd7aea/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tjost-fixes.patch
Type: text/x-patch
Size: 9112 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111116/69dd7aea/attachment-0003.bin>
-------------- next part --------------
Peace
--
Pieter
[1] id:"874ny4fcdz.fsf at praet.org"
[2] id:"87ipn3obvi.fsf at praet.org"
[3] id:"87fwi7obso.fsf at praet.org"
More information about the notmuch
mailing list