[PATCH] emacs: notmuch-hello: respect notmuch-help's wishes
Pieter Praet
pieter at praet.org
Wed Nov 16 02:56:59 PST 2011
On Fri, 11 Nov 2011 12:29:34 -0500, David Bremner <david at tethera.net> wrote:
> On Sat, 16 Apr 2011 15:12:43 +0200, Pieter Praet <pieter at praet.org> wrote:
> > Calling notmuch-help in notmuch-hello-mode results in error
> > "apply: Wrong type argument: listp, keymap"
>
> Hi Pieter;
>
> I'm a little confused here. I still get the same error after applying
> your patch. Is there a followup patch I missed?
>
Hmm, it works here...
I've tried cooking up a proper test:
#+begin_src sh
test_begin_subtest "Help in notmuch-hello"
test_emacs '(let ((major-mode '\''notmuch-hello-mode))
(notmuch-help)
(test-output))'
cat <<EOF >EXPECTED
Placeholder for actual expected output...
EOF
test_expect_equal_file OUTPUT EXPECTED
#+end_src
... but I'm making some stupid mistake, because it doesn't output
*anything*, not even for `notmuch-search-mode' and `notmuch-show-mode'.
It works when running Emacs like this, though:
#+begin_src sh
emacs --no-init-file --eval '(progn
(add-to-list '\''load-path (concat
(getenv "HOME") "/src/dev/notmuch/emacs"))
(require '\''notmuch)
(notmuch-hello)
(notmuch-help))'
#+end_src
Anyways, it's a rather lame patch (even more so when taking my horrible
typo into consideraton) so I wouldn't waste too much time on it if I
were you. Duplication is evil, so this bug should be fixed in
`notmuch-substitute-one-command-key-with-prefix' instead.
> David
Peace
--
Pieter
More information about the notmuch
mailing list