[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

Austin Clements amdragon at MIT.EDU
Fri Nov 11 18:49:41 PST 2011


Good idea, but this introduces a dependency on netcat.  Would it work
to simply kill the SMTP dummy?

Quoth Tomi Ollila on Nov 11 at  1:38 am:
> If mail sending from emacs fails before it has chance to connect
> to the smtp-dummy mail server, the opportunistic QUIT message
> sending makes smtp-dummy to exit.
> ---
>  test/test-lib.sh |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index af723ad..57cb088 100755
> @@ -397,6 +397,8 @@ emacs_deliver_message ()
>  	   (insert \"${body}\")
>  	   $@
>  	   (message-send-and-exit))" >/dev/null 2>&1
> +    # opportunistically quit smtp-dummy in case above fails.
> +    echo QUIT | nc 127.0.0.1 25025 >/dev/null 2>&1
>      wait ${smtp_dummy_pid}
>      notmuch new >/dev/null
>  }


More information about the notmuch mailing list