[PATCH] Repeatability when copying a whole directory into a new one.

[Pieter Praet]

On Mon, 31 Oct 2011 23:59:49 -0300, David Bremner <david at tethera.net> wrote:
> On Fri, 30 Sep 2011 01:26:46 +0200, Thomas Schwinge <thomas at schwinge.name> wrote:
> > This new test currently fails -- but it shouldn't.
> > ---
> > 
> > Hi!
> > 
> > I found this while manually copying directories and running notmuch new.
> > 
> > Am I just too sleepy at this time, or is it another DB vs. directory
> > mtime issue?
> > 
> >      BROKEN Repeatability when copying a whole directory into a new one
> >             --- new.18.expected     2011-09-29 23:23:39.000000000 +0000
> >             +++ new.18.output       2011-09-29 23:23:39.000000000 +0000
> >             @@ -1,2 +1 @@
> >             -Processed 51 total files in almost no time.
> >              No new mail.
> 
> I'm a bit confused here too. When the files are removed, the "notmuch new"
> sent to /dev/null in your test detects the deletes as renames. Shouldn't
> the copies be detected as duplicates or something?
> 

They should.

Applying any one of the attached patches makes the test pass;
I vote "directory mtime issue".


-------------- next part --------------
A non-text attachment was scrubbed...
Name: update-dir-mtime.patch
Type: text/x-patch
Size: 329 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111103/71fe6288/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cp-without-archive-opt.patch
Type: text/x-patch
Size: 612 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111103/71fe6288/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cp-to-other-dir.patch
Type: text/x-patch
Size: 391 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111103/71fe6288/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cp-dir-content.patch
Type: text/x-patch
Size: 622 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111103/71fe6288/attachment-0003.bin>
-------------- next part --------------


> d
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Peace

-- 
Pieter