[PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil.

[Jameson Graef Rollins]

On Sun, 23 Oct 2011 12:18:53 -0300, David Bremner <david at tethera.net> wrote:
> We keep the lib/xutil.c version. As a consequence, also factor out
> _internal_error and associated macros.  It might be overkill to make a
> new file error_util.c for this, but _internal_error does not really
> belong in database.cc.
> ---
> 
> This turned out to be more disruptive than I thought. On the other
> hand, having two copies of xutil.c seems like a recipe for disaster.
> I wanted to factor out the logic in xregcomp so I could use it in
> situations where miscompilation is not an internal error, but more
> likely a user error.

Hey, David.  Other than the fact that git couldn't digest the encoding
of this message, I would say the patch looks very reasonable to me.  It
looks to me like the right thing to do, and that you're doing it in a
reasonable way.

Once I got over the encoding issues, this patch applied cleanly and
seems to be working fine.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111030/2ff80fbf/attachment.pgp>