[PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

Jameson Graef Rollins jrollins at finestructure.net
Wed Oct 26 19:52:59 PDT 2011


On Tue, 11 Oct 2011 01:46:43 +0200, Thomas Schwinge <thomas at schwinge.name> wrote:
> On Sun,  9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> >  (defun notmuch-show-get-message-id ()
> >    "Return the message id of the current message."
> > -  (concat "id:\"" (notmuch-show-get-prop :id) "\""))
> > +  (concat "\"" (notmuch-show-get-prop :id) "\""))
> 
> Shouldn't the double quotes be removed here, too?  (And be re-added in
> the other places where id: is added.)

In point of fact, do we need these quotes around message IDs at all?
Can message IDs have characters that would need to be escaped for the
shell?

This seems to also be related to the issue brought up by Erlend Simonsen
in [0], where emacs 24 seems to be shell-quoting things as needed.

So maybe these quotes aren't actually needed at all?...

jamie.

[0] id:87y5w9w6dm.fsf at fudge.hue.no
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111026/280cc7ba/attachment.pgp>


More information about the notmuch mailing list