[PATCH 2/4] emacs: Support a message-mode switch function in notmuch-mua

[Thomas Jost]

On Mon, 10 Oct 2011 08:50:52 -0700, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> However, I find the customization variable a bit clunky.  Since I wasn't
> presented with any options in the customization, I didn't know what to
> put in.  I copy and pasted "switch-to-buffer-other-frame" into the
> customization field but that didn't work since I didn't protect the
> function name.  Finally I got it to work by putting in
> "'switch-to-buffer-other-frame" (with the initial "'").
> 
> So I definitely love this feature, but can we make the customization
> work better so that it's easier for the user to figure out how to set
> it?

Heh, I had just tested it using "(setq ...)", not using M-x customize.
And yes, when using the customization interface it's not clear at all.
The problem is that the ":options" property of customizable variables
is only useful for hooks or alists, not for functions (but that isn't
documented anywhere, I had to dig in custom.el to find this).

So I think the best way to make that clearer and easier to figure out is
just to add more details in the docstring. I'll send a patch as a reply
to this message.

> Another question about this feature: how do you make the window
> (frame) go away after the email is sent?

I do this:
    (add-hook 'message-sent-hook 'delete-frame)

(added to the doc too).

Thanks for your review :)

-- 
Thomas/Schnouki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111011/73d694a6/attachment.pgp>