[PATCH] Do not import notmuch in setup.py (again).

Michael Hudson-Doyle michael.hudson at canonical.com
Wed Aug 24 03:46:15 PDT 2011


rOn Wed, 24 Aug 2011 09:20:51 +0200, Sebastian Spaeth <Sebastian at SSpaeth.de> wrote:
> On Wed, 24 Aug 2011 12:45:34 +1200, Michael Hudson-Doyle <michael.hudson at canonical.com> wrote:
> > Revert part of 8826f.  As explained in c39b492c, importing notmuch in setup.py breaks make -f debian/rules clean in an environment that does not have notmuch installed already.
> 
> Ahh, sorry, I must have missed that patch (or forgotten about it). I
> solved this now by having the version number in version.py (which
> contains nothing else, so David Bremner can easily overwrite it with
> makefile magic :-)).

Ah cool.

> @David, feel free to automagically modify (or overwrite)
> bindings/python/notmuch/version.py.
> 
> We read in version.py using execfile() and verify that getting the
> version number actually worked.
> 
> Sorry, I did not apply your patch as I had fixed this before even seeing
> your patch.

No worries.  5dc189c seems to be building fine so far...

Cheers,
mwh


More information about the notmuch mailing list