[PATCH] libnotmuch: only build symbols list after the modules are built

David Bremner david at tethera.net
Wed Jul 20 10:07:24 PDT 2011


On Wed, 20 Jul 2011 14:38:18 +0200, Thomas Jost <schnouki at schnouki.net> wrote:
> If the notmuch.sym target does not explicitly depend on $(libnotmuch_modules),
> gen-version-script.sh may be run before all the .o files are created. This can
> be observed when doing a parallel build on a machine with many cores:
>   $ make -j
>   ...
>   sh lib/gen-version-script.sh lib/notmuch.h lib/filenames.o lib/string-list.o
>   lib/libsha1.o lib/message-file.o lib/messages.o lib/sha1.o lib/tags.o
>   lib/xutil.o lib/database.o lib/directory.o lib/index.o lib/message.o

Hi Thomas;

Your patch looks sensible.  If you could shorten up the commit message a
bit, probably by putting the make output after '---' and adjusting the
rest of the text, I'll be happy to push it.

d


More information about the notmuch mailing list