[PATCH 5/6] test: emacs: `notmuch-search-operate-all' should operate on threads, not messages

Pieter Praet pieter at praet.org
Sun Jul 10 08:55:34 PDT 2011


In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"),
`notmuch-search-operate-all' ("*") should operate on matching threads
instead of matching messages.

This test exposes an existing bug, so is currently failing.
It should be fixed in the next commit.

Signed-off-by: Pieter Praet <pieter at praet.org>
---
 test/emacs-search-operate-all |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/emacs-search-operate-all b/test/emacs-search-operate-all
index 2bd50ba..48326c8 100755
--- a/test/emacs-search-operate-all
+++ b/test/emacs-search-operate-all
@@ -7,7 +7,7 @@ EXPECTED=$TEST_DIRECTORY/emacs.expected-output
 
 add_email_corpus
 
-test_begin_subtest "Add/remove tags to/from all matching messages."
+test_begin_subtest "Add/remove tags to/from all matching threads."
 test_emacs '(notmuch-search "tag:inbox AND tags")
 	    (notmuch-test-wait)
 	    (notmuch-search-operate-all "+matching -inbox")
@@ -15,13 +15,13 @@ test_emacs '(notmuch-search "tag:inbox AND tags")
 	    (notmuch-test-wait)
 	    (test-output)'
 cat <<EOF >EXPECTED
+  2009-11-18 [2/2]   Ingmar Vanhassel, Carl Worth  [notmuch] [PATCH] Typsos (matching unread)
   2009-11-18 [3/3]   Adrian Perez de Castro, Keith Packard, Carl Worth  [notmuch] Introducing myself (matching signed unread)
-  2009-11-18 [1/3]   Carl Worth, Israel Herraiz, Keith Packard       [notmuch] New to the list (inbox matching unread)
+  2009-11-18 [3/3]   Israel Herraiz, Keith Packard, Carl Worth   [notmuch] New to the list (matching unread)
   2009-11-18 [2/2]   Keith Packard, Carl Worth    [notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (matching unread)
-  2009-11-18 [1/2]   Keith Packard, Alexander Botero-Lowry    [notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox matching unread)
+  2009-11-18 [2/2]   Keith Packard, Alexander Botero-Lowry    [notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (matching unread)
   2009-11-18 [1/1]   Jan Janak            [notmuch] [PATCH] notmuch new: Support for conversion of spool subdirectories into tags (matching unread)
   2009-11-18 [1/1]   Stewart Smith        [notmuch] [PATCH] Fix linking with gcc to use g++ to link in C++ libs. (matching unread)
-  2009-11-17 [1/2]   Ingmar Vanhassel, Carl Worth  [notmuch] [PATCH] Typsos (inbox matching unread)
 End of search results.
 EOF
 test_expect_equal_file OUTPUT EXPECTED
-- 
1.7.5.4



More information about the notmuch mailing list