[PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches

Dmitry Kurochkin dmitry.kurochkin at gmail.com
Thu Jul 7 01:22:37 PDT 2011


On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe <daniel.schoepe at googlemail.com> wrote:
> Hi Dmitry,
> 
> On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> > Why do we need to remove `goto-address-mode' overlays if it is not
> > enabled ((goto-address-mode t) is below is removed)?
> > [..]
> > `goto-address-mode' creates buttons not only for email addresses but
> > also for URLs.  Do we loose it now?
> 
> Everything `goto-address-mode' does is still in effect, I just replaced
> (goto-address-mode t) by a call to `goto-address-fontify-region' in
> notmuch-show-buttonise-links, to ensure that the id links will be
> buttonised (and the overlay removed after it's actually been inserted)
> _after_ goto-address does its thing.
> 
> I could also have left (goto-address-mode t) in and jit-register-lock'ed
> notmuch-show-buttonise-links before that, but then I would be relying on
> the fact that fontifiers that are registered first, will be run last. As
> far as I can tell this is just an implementation detail and might change
> some day.
> 

Thank you and Pieter for the answers.  I missed
`goto-address-fontify-region' on the first look.

Regards,
  Dmitry

> Cheers,
> Daniel


More information about the notmuch mailing list