[PATCH] test: do not hide test_emacs errors

Dmitry Kurochkin dmitry.kurochkin at gmail.com
Thu Jun 30 19:23:48 PDT 2011


Do not redirect test_emacs stderr to /dev/null.  Test_emacs uses
emacsclient(1) now and it does not print unwanted messages (like
those from `message') to stderr.  But it does print useful
errors, e.g. when emacs server connection fails, given expression
is not valid or undefined function is called.
---
 test/emacs       |    4 ++--
 test/test-lib.sh |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/emacs b/test/emacs
index 53f455a..dbe8d9e 100755
--- a/test/emacs
+++ b/test/emacs
@@ -261,13 +261,13 @@ test_begin_subtest "Save attachment from within emacs using notmuch-show-save-at
 # save as archive to test that Emacs does not re-compress .gz
 test_emacs '(let ((standard-input "\"attachment1.gz\""))
 	      (notmuch-show "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a at mail.gmail.com")
-	      (notmuch-show-save-attachments))' > /dev/null 2>&1
+	      (notmuch-show-save-attachments))'
 test_expect_equal_file attachment1.gz "$EXPECTED/attachment"
 
 test_begin_subtest "Save attachment from within emacs using notmuch-show-save-part"
 # save as archive to test that Emacs does not re-compress .gz
 test_emacs '(let ((standard-input "\"attachment2.gz\""))
-	      (notmuch-show-save-part "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a at mail.gmail.com" 5))' > /dev/null 2>&1
+	      (notmuch-show-save-part "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a at mail.gmail.com" 5))'
 test_expect_equal_file attachment2.gz "$EXPECTED/attachment"
 
 test_begin_subtest "View raw message within emacs"
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 22e387e..37f007a 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -394,7 +394,7 @@ emacs_deliver_message ()
 	   (message-goto-body)
 	   (insert \"${body}\")
 	   $@
-	   (message-send-and-exit))" >/dev/null 2>&1
+	   (message-send-and-exit))"
     wait ${smtp_dummy_pid}
     notmuch new >/dev/null
 }
-- 
1.7.5.4



More information about the notmuch mailing list