[PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

Carl Worth cworth at cworth.org
Wed Jun 29 07:41:12 PDT 2011


On Wed, 29 Jun 2011 06:47:37 -0700, Carl Worth <cworth at cworth.org> wrote:
> On Wed, 29 Jun 2011 03:10:54 -0400, Austin Clements <amdragon at MIT.EDU> wrote:
> > +     * XXX Bug workaround: If this is a new directory, we *must*
> > +     * update the mtime; otherwise the next run will see the 0 mtime
...
> I like to reserve "XXX" as an indication that some further work is
> necessary.

Reading your other mail now, I see that there are bugs here and that you
do want to eliminate the new_directory optimization. That wasn't clear
to me from the comment above.

So the XXX is probably fine, but could perhaps give a little more
indication of what could be done to eliminate the bug.

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/4f487e2a/attachment.pgp>


More information about the notmuch mailing list