[PATCH] Do not attept to output part raw if part is not GMimePart.

Jameson Graef Rollins jrollins at finestructure.net
Mon Jun 27 14:44:25 PDT 2011


On Mon, 27 Jun 2011 16:43:36 -0400, Austin Clements <amdragon at mit.edu> wrote:
> Just to clarify my understanding, --format=raw is only intended to
> work on either the whole message (special-cased in do_show_single) or
> a leaf MIME part, and in any other case, it will output nothing?  The
> raw output test cases seem pretty thin.

Hey, Austin.  The raw part output works for *any* part, be it leaf part,
multipart, message/rfc822, etc.  I added a bunch of tests for raw part
output that should cover all of this, although I don't think they've
been pulled into master yet.

I think there are a lot of open questions about what should be output
for multipart raw.  We should output _something_, though.  I think we
can fix all of this up for 0.7, based on the work you've already done,
after 0.6 is released.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110627/0bef3f1e/attachment-0001.pgp>


More information about the notmuch mailing list