[PATCH] libnotmuch: fix typos in CLEAN setting, add file

david at tethera.net david at tethera.net
Sat Jun 25 05:45:58 PDT 2011


From: David Bremner <bremner at debian.org>

- c0961e6 introduced a missing slash between $(dir)$(LIBNAME) and missing
  $(dir) in front of libnotmuch.a
- cdf1c70a created a file $(dir)/notmuch.h.gch and neglected to
  add it to CLEAN
---

Here is an updated version. I'm not sure the best way to do a test of
the cleaning; maybe we should ship a MANIFEST file containing the
output of git ls-files. I'm not sure how much churn this would cause
in git.  Perhaps it could be treated like version, and generated from
git if possible. In any case I guess this couldn't really be part of
our regular test suite, because all the other tests would fail ;).

 lib/Makefile.local |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/Makefile.local b/lib/Makefile.local
index a33ba34..eaa8af4 100644
--- a/lib/Makefile.local
+++ b/lib/Makefile.local
@@ -103,4 +103,6 @@ install-$(dir): $(dir)/$(LIBNAME)
 	$(LIBRARY_INSTALL_POST_COMMAND)
 
 SRCS  := $(SRCS) $(libnotmuch_c_srcs) $(libnotmuch_cxx_srcs)
-CLEAN := $(CLEAN) $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME) $(dir)$(LIBNAME) libnotmuch.a notmuch.aux notmuch.sym
+CLEAN += $(libnotmuch_modules) $(dir)/$(SONAME) $(dir)/$(LINKER_NAME)
+CLEAN += $(dir)/$(LIBNAME) $(dir)/libnotmuch.a notmuch.aux notmuch.sym
+CLEAN += $(dir)/notmuch.h.gch
-- 
1.7.5.3



More information about the notmuch mailing list