[PATCH] Always return the empty string if decryption tries to demand a password

Carl Worth cworth at cworth.org
Fri Jun 3 16:15:14 PDT 2011


On Fri,  3 Jun 2011 19:03:08 -0400, Daniel Kahn Gillmor <dkg at fifthhorseman.net> wrote:
> The notmuch binary is not in the business of doing interactive
> prompting with the user.  If credentials are needed for decryption,
> they should be supplied to the decrypting processes some other way
> (e.g. gpg-agent).
> 
> Previously, we returned a NULL function pointer for the
> request_passwd() function, which may have cause segmentation faults
> with some versions of gmime.

Cool. This fixes my segfaults, so thanks!

> +    return g_strdup ("");

Is the above correct? Or is it a memory leak? (If it's not a leak, then
GMime really has some bizarre ownership semantics.)

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110603/3aa2afae/attachment.pgp>


More information about the notmuch mailing list