normalizing part numbering across PGP/MIME processing
Jameson Graef Rollins
jrollins at finestructure.net
Sat May 28 14:31:08 PDT 2011
On Fri, 27 May 2011 17:53:44 -0700, Carl Worth <cworth at cworth.org> wrote:
> So, well done, Jameson! You've been extremely patient as I sat on this
> patch series for *so* long, and then made you rebuild it so many
> times. I hope you think the rebuilds were at least worth it for the much
> cleaner final state, (I know that the useless waiting wasn't worth it).
w00t! Thanks so much, Carl! I definitely think the whole branch turned
out to be a lot cleaner in the end.
> That said, here are the (minor) issues I have with the series:
>
> * More tests should be switched to the new text_expect_equal_file
>
> This isn't a problem with the series---but will be a nice
> fix. I think the current "notmuch search --output=tags *" is
> broken due to a missing final newline---or at least has been
> broken that way recently. So it will be nice to have this
> support for testing a final newline.
Yes, I agree. I'm about to send a patch series to the list that
includes a bunch of random stuff that should be include in 0.6, and it
includes some of these fixes.
> * Should we set the crypto option to verify/decrypt by default?
>
> That would certainly be convenient for me at least.
>
> For people who don't want this, they can set the variable to
> nil. But then they'll still have the following issue:
I don't really have an opinion on this. I have it set now, so whether
or not it's set by default doesn't make much difference to me.
> * I'm not a fan of the M-RET option for decrypting a message
>
> If someone is going to have encrypted messages not decrypted by
> default, then they can currently decrypt by opening the message
> with M-RET. But I think in common use, the user is likely to
> only realize too late that they want to decrypt the message.
>
> So what I'd love to see is a keybinding for decrypting a message
> from the view of the message itself. (One natural place would be
> by activating the button of the encrypted part---but a
> keybinding to review with decryption would be fine too---likely
> easier to code and easier to use.)
I agree it would definitely be better to have the redisplay happen from
inside the message show. That would be much cleaner and more intuitive.
It will require a bit of work to add something like a "redisplay" in
notmuch-show, but I see no reason it can't be done.
> * I can't actually get decryption to work for me. :-(
>
> When I run "notmuch show --decrypt" on a message encrypted with
> my public key I get a segfault within libgmime, specifically in
> the g_mime_session_request_passwd function.
Yikes!
> My first guess is that this is due to the fact that gpg-agent
> can't be run on my system (Debian unstable):
>
> $ gpg-agent
> gpg-agent: symbol lookup error: /usr/lib/libassuan.so.0: undefined symbol: gpg_err_set_errno
>
> I've got a Debian bug report queued up for this.
hrm, that's very strange, unfortunately I'm not sure what's happening
there. Bug in gpg-agent, I assume?
> I also tried running the same "notmuch show" command without
> gpg-agent installed. How is libgmime supposed to actually
> request a password in a case like this?
That's a good question, actually, and I don't actually know the answer.
Ok, so more release-candidate/0.6 patches to follow.
Thanks again for pushing all this stuff through, Carl.
jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110528/406b2cc9/attachment.pgp>
More information about the notmuch
mailing list