[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

Dmitry Kurochkin dmitry.kurochkin at gmail.com
Thu May 26 14:42:22 PDT 2011


On Thu, 26 May 2011 14:31:30 -0700, Carl Worth <cworth at cworth.org> wrote:
> On Thu, 26 May 2011 14:26:34 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> > It is called indirectly.  What is the best way to fix it?  I imagine
> > that we can replace `isearch-range-invisible' function with another one,
> > which would call the fixed function if some special variable is set, or
> > if we are searching in a notmuch-show view.  Otherwise it would call the
> > original function.
> 
> I'm not sure what the best approach would be. I'd like to be a good
> "emacs citizen" but I don't know what the best way to do that is here.
> 

Agreed on being a good "emacs citizen".

> If we can predict what the first emacs release will be that contains the
> fix, then we could restrict our kludge here to older, unfixed
> emacs. That would help avoid some problems with "bad citizenship here".
> 
> I'm willing to take whatever you this is best here.
> 

I have just send two more patches to this thread.  One with new tests.
Another with a workaround for the bug.  The workaround should not break
anything since it affects only notmuch-show mode.

Regards,
  Dmitry

> -Carl
> 
> -- 
> carl.d.worth at intel.com
Non-text part: application/pgp-signature


More information about the notmuch mailing list