[PATCH] test: use `princ' instead of `message' calls in emacs tests

Jameson Graef Rollins jrollins at finestructure.net
Tue May 10 02:12:40 PDT 2011


On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote:
> The patch replaces all (message (buffer-string)) calls in emacs
> tests with (princ (buffer-string)).  This avoids accidentally
> interpreting '%' as format specifiers and makes code simpler
> because we do not need to capture stderr.
> 
> Also, the patch works around an Emacs (23.3+1-1 on current Debian
> Unstable) segfault in "Ensure that emacs doesn't drop results"
> test.  Note: the segfault does not happen on every test run.
> Though, it seems to be consistently reproducible if the test uses
> 300 messages instead of 30.  Hopefully, it is the crash described
> in Emacs bug #8545 [1] which is already fixed.

This is a great catch, Dmitry.  Thank you.  And I'm glad you and Austin
figured out the best solution.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110510/3f91699d/attachment-0001.pgp>


More information about the notmuch mailing list