[PATCH] use custom-face-edit value-type in notmuch-search-line-faces

[Pieter Praet]

On Sat, 26 Mar 2011 22:26:26 -0700, Jameson Rollins <jrollins at finestructure.net> wrote:
> On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> > This enables the proper face customization UI for
> > notmuch-search-line-faces.
> 
> Hey, folks.  amdragon was the one who figured out that custom-face-edit
> was the correct value-type to use to get the face customization ui for
> the notmuch-search-line-faces list.  However, he seems to think this
> might not be the right solution.  Austin: care to comment?
> 
> jamie.
Non-text part: application/pgp-signature
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

No idea why it wouldn't be a good solution, only "negative" thing I
could find was a comment "FIXIT: Use a better equivalent to
custom-face-edit if there is one" in diredful.el:312 [1]

FWIW, in Org-mode (org-todo-keyword-faces @ org-faces.el:355-371 [2],
exactly the same use case) they do it like this:

    :type '(repeat
            (cons
             (string :tag "Keyword")
             (choice :tag "Face   "
              (string :tag "Color")
              (sexp :tag "Face")))))


[1] http://www.emacswiki.org/emacs-en/diredful.el
[2] http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org-faces.el;h=7bb3055c7d707b069ee826dfff54b8e441566e3e;hb=HEAD