[PATCH] use custom-face-edit value-type in notmuch-search-line-faces

[Austin Clements]

On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins <jrollins at finestructure.net>
wrote:
> On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins <
jrollins at finestructure.net> wrote:
>> This enables the proper face customization UI for
>> notmuch-search-line-faces.
>
> Hey, folks.  amdragon was the one who figured out that custom-face-edit
> was the correct value-type to use to get the face customization ui for
> the notmuch-search-line-faces list.  However, he seems to think this
> might not be the right solution.  Austin: care to comment?

My concern is that it's unclear if the custom-face-edit widget is considered
a public interface, or if it's internal to customize and thus could change
at any time. These things are always a bit murky in Emacs. custom-face-edit
has been around for a few major versions, though it only recently (somewhere
between Emacs 22 and 23) became embeddable in a customize widget like this.
We should just ask on an Emacs mailing list if this is okay, or if it will
break catastrophically and without warning at some point (or if there's a
more official solution).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110327/85839094/attachment.html>