[PATCH] emacs: Avoid regexp overflow when tidying citations.

Carl Worth cworth at cworth.org
Tue Nov 16 11:57:22 PST 2010


On Fri, 12 Nov 2010 12:50:02 +0000, David Edmondson <dme at dme.org> wrote:
> Declare `notmuch-wash-tidy-citations-max', which is the largest region
> that `notmuch-wash-tidy-citations' will attempt to improve.

Hi David,

Could you add a test case for whatever bug is being fixed here?

I'm a little concerned about giving the user a tuning knob which appears
to have a somewhat arbitrary default, and also without providing much
guidance to the user on how to set that particular knob.

I'd feel better if the code could somehow "know" when it needs to stop
tidying well enough that we would feel fine just not offering the knob
at all.

Thanks,

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20101116/7324a3ee/attachment-0001.pgp>


More information about the notmuch mailing list