[PATCH] Remove bcc header from notmuch reply.

[Jameson Rollins]

Notmuch reply should not be Bcc'ing the sender by default.  This is
not the appropriate way to save copies of sent mail (which should
probably be handled by an Fcc header) and it doesn't give the user the
option to not be bcc'd.  This is really something that should be
handled by the reader UI.  For instance, emacs message-mode can easily
be configured to add Bcc's if the user wishes.
---
Now that we finally have good built-in fcc support, we can finally get
rid of the annoying bcc in notmuch-reply.

This is a resubmit of an old patch that has been rebased against the
current head of cworth/master.

 notmuch-reply.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index fd1de3b..856d5e9 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -267,8 +267,7 @@ add_recipients_from_message (GMimeMessage *reply,
     } reply_to_map[] = {
 	{ "reply-to", "from", GMIME_RECIPIENT_TYPE_TO  },
 	{ "to",         NULL, GMIME_RECIPIENT_TYPE_TO  },
-	{ "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  },
-	{ "bcc",        NULL, GMIME_RECIPIENT_TYPE_BCC }
+	{ "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  }
     };
     const char *from_addr = NULL;
     unsigned int i;
@@ -481,9 +480,6 @@ notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_
 	g_mime_object_set_header (GMIME_OBJECT (reply),
 				  "From", from_addr);
 
-	g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",
-			   notmuch_config_get_user_primary_email (config));
-
 	in_reply_to = talloc_asprintf (ctx, "<%s>",
 			     notmuch_message_get_message_id (message));
 
@@ -558,9 +554,6 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_config_t *config, notmuch_q
 
 	(void)add_recipients_from_message (reply, config, message);
 
-	g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",
-			   notmuch_config_get_user_primary_email (config));
-
 	reply_headers = g_mime_object_to_string (GMIME_OBJECT (reply));
 	printf ("%s", reply_headers);
 	free (reply_headers);
-- 
1.7.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100428/4701b447/attachment.pgp>