[PATCH] Rename already used counter var i

[Carl Worth]

On Tue, 27 Apr 2010 14:57:25 +0200, Sebastian Spaeth <Sebastian at SSpaeth.de> wrote:
> From: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
> i is already used in a for loop at this point, so using i here again
> broke notmuch-reply (it would just hang). Use j instead of i here.

Thanks for the fix.

>  Aneesh noticed this bug and provided a fix for it. IMO it warrants a 0.3.1
>  release. notmuch-reply hanging indefinitely is not going to make grumpy
>  editors happy.


Definitely.

For a point release like 0.3.1 I'm going to insist on a test case that
demonstrates each regression being fixed. Does someone know what it
takes to make a mail trigger this bug?

>  Also despite a documentation blurb above the main snippet of
>  code, I find it pretty much black magic what is being done here. But then 
>  I don't really know C....

I find it pretty much black magic too. I rewrote one piece of
black-magic code late last night when we noticed it was causing crashes
and valgrind was complaining. I'll dive in and give this chunk of code
some similar treatment.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100427/dc70a40b/attachment.pgp>