[PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

Carl Worth cworth at cworth.org
Mon Apr 26 10:41:59 PDT 2010


On Mon, 26 Apr 2010 17:30:04 +0100, David Edmondson <dme at dme.org> wrote:
> On Mon, 26 Apr 2010 09:11:07 -0700, Dirk Hohndel <hohndel at infradead.org> wrote:
> > This is lacking a committ message...

Thanks for the review, Dirk! Much appreciated.

> I wasn't sure what else to say.

Here's what I came up with in my --amend of the commit message:

    emacs: `notmuch' should display the `notmuch-hello' interface
    
    Reviewed-by: Carl Worth <cworth at cworth.org>
    
    The notmuch-hello functionality is now sufficiently useful that we
    want to make it the default view of notmuch for new users. This also
    effectively hides the "hello" name from the user, so we'll be free to
    change that in the implementation if necessary.
    
    This change also shuffles the requires between notmuch.el and
    notmuch-hello.el. This fixes things so that our documented (require
    'notmuch) is sufficient for getting the notmuch-hello functionality.
    
    Finally, the shuffling caused the notmuch-search-oldest-first variable
    from one file to the other. While doing that, give this variable the
    defcustom treatment for easier customization.

Pushed.

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100426/29dc6d70/attachment.pgp>


More information about the notmuch mailing list