[PATCH] Fix linker error from insufficient LDFLAGS

[Carl Worth]

On Thu, 22 Apr 2010 18:20:27 -0400, Ben Gamari <bgamari.foss at gmail.com> wrote:
> It seems that LDFLAGS have recently been reorganized, along with the
> introduction of a notmuch-shared rule. Unfortunately, the LDFLAGS used
> in notmuch-shared don't include CONFIGURE_LDFLAGS. This caused linking
> to fail with the following,

What system is this on?

> -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch
> +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(CONFIGURE_LDFLAGS)
>  FINAL_NOTMUCH_LINKER = CC
>  ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
>  FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS)

Note that CONFIGURE_LDFLAGS *is* conditionally added a couple of lines
later.

In my testing on Linux, these flags aren't needed/wanted for linking
notmuch-shared. And I believe I tested the conditional assignment such
that it gets enabled on OS X at least, where these additional flags are
needed.

So perhaps you've just got a system where we need to detect that
LINKER_RESOLVES_LIBRARY_DEPENDENCIES should be set to 0?

Let me know,

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100423/78ab1b90/attachment.pgp>