pull request
Carl Worth
cworth at cworth.org
Mon Apr 19 11:07:40 PDT 2010
On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson <dme at dme.org> wrote:
> This is the same set rebased onto 0.2.
Thanks for these, David!
> commit 8586a86b9dd4ed2406a2fbda6c08bdc6a598cfd8
> debian: git should ignore packaging intermediate files
I committed an alternate version of this, (with a new debian/.gitignore
file). I used more wildcarding too. And I couldn't actually find how to
make all these files appear. If you need more ignores, just let me know
(and let me know what commands trigger those, since I'm curious).
> commit f5de1bb5b4216a1950f6aa5f471c9964e4d0e521
> emacs/notmuch-show.el: Avoid passing unintended format strings to
> `message'
Thanks. I've committed this.
> commit 4159baa2166a3410663adc200f91145edf8e0e13
>
> emacs/notmuch.el: Enable `hl-line-mode' in `notmuch-search-mode'
I've got some misgivings about this one. First, notmuch-search-hook is
a hook for the user to manipulate, while the hl-line-mode functionality
is something that should be on by default. That is, if the user happens
to set the search-hook then the hl-line-mode shouldn't magically
disappear.
Meanwhile, I *am* getting hl-line-mode in notmuch-search-mode
already. I'm not sure where that's coming from. (I also don't know
what's up with the current "options '(hl-line-mode)" which doesn't seem
right.)
> commit 53c4e64943d09b07e75c9258fc9f954c87a490d6
> json: Avoid calling strlen(NULL)
That commit message describes this hunk of the patch:
> + if (str == NULL)
> + str = "";
> +
> return (json_quote_chararray (ctx, str, strlen (str)));
But this other hunk looks independent. What's going on here?
> - if (len == 0)
> - return (char *)"\"\"";
> -
So I haven't committed this piece yet.
That brings me up to the big JSON rewrite, which I'll start testing and
review in a separate reply.
-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100419/6484ea7c/attachment-0001.pgp>
More information about the notmuch
mailing list