[notmuch] [PATCH] notmuch-show: add tags to json output

Jameson Rollins jrollins at finestructure.net
Mon Mar 1 09:35:06 PST 2010


On Mon, 01 Mar 2010 13:26:52 -0400, David Bremner <bremner at unb.ca> wrote:
> On Mon,  1 Mar 2010 16:39:06 +0100, Sebastian Spaeth <Sebastian at SSpaeth.de> wrote:
> > The previous json patches forgot to add the notmuch tags to the json
> > output. This is inconsistent to the text output so here they are. We
> > just output a 'tags' field that sends a space delimited list of
> > json-encoded notmuch tags.
> > 
> > Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
> 
> I agree we need tags in json output, but I think that making the client
> parse the string of (space delimited?) tags defeats a bit the purpose of
> having json output.  What do you think about 
> 
>        "tags": [ "inbox", "unread" ] 
> 
> instead of 
> 
>         "tags": "inbox unread"

I agree that having the JSON "tags" output field be an array of strings
makes the most sense.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100301/0fd37ca6/attachment.pgp>


More information about the notmuch mailing list