[notmuch] [PATCH] d_type fix

[Geo Carncross]

A review of notmuch-new.c shows three uses of ->d_type:

Near line 153, in _entries_resemble_maildir() we can simply allow for
DT_UNKNOWN. This would fail if people have MH-style folders which have
three folders called "new" "cur" and "tmp", but that seems unlikely, in
which case the "tmp" folder would simply not be scanned.

Near line 273 in add_files_recursive() we have another check. If
DT_UNKNOWN, we fall through, then add_files_recursive() does a stat
almost immediately, returning with success if the path isn't a
directory.

Thus, the fallback is already written.

Finally, near line 343, in add_files_recursive() (a long function) we
have another check. Here we can simply treat DT_UNKNOWN as DT_LNK, since
the logic for the stat() results are the same.

Attached is a patch which was tested with reiserfs. It should also work
with xfs.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: notmuch_new_d_type_fix.patch
Type: text/x-patch
Size: 1144 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100121/29b03255/attachment.bin>