[notmuch] [PATCH] Add post-add and post-tag hooks

Tomas Carnecky tom at dbservice.com
Tue Dec 22 22:57:21 PST 2009


On 12/23/09 12:02 AM, Olly Betts wrote:
> Tomas Carnecky writes:
>> #if defined(__sun__)
>> 	... sprintf, stat etc
>> #else
>> 	(void) path;
>> 	return dirent->d_type == DT_DIR;
>> #endif
>
> Rather than a platform-specific check, it would be better to check if DT_DIR
> is defined.
>
> Beware that even on Linux (where the d_type field is present), it may always
> contain DT_UNKNOWN for some filesystems, so you really should check for that
> case and fall back to using stat() instead.

Currently configure is a simple shell script and not some autoconf 
magic. And I don't know how eager Carl is to use autoconf, scons, cmake 
or similar.

tom



More information about the notmuch mailing list