[notmuch] [PATCH 1/2] New function notmuch-search-operate-all: operate on all messages in the current query.

[Jed Brown]

On Fri, 27 Nov 2009 06:02:45 -0800, Carl Worth <cworth at cworth.org> wrote:
> Since this operates via a single call to "notmuch tag" you might mention
> here that all tag removals occur before any tag additions.

I was unaware of this point, if I do

  notmuch tag -inbox +star tag:inbox some-expression

I will have starred nothing?

> > +	(unless (string-match-p "^[\+\-][_\+\-\\w]+$" (car words))
> > +	  (error "Action must be of the form `+thistag -that_tag'"))
> 
> The error message has inconsistent "thistag" and "that_tag".

That was somewhat intentional to illustrate that non-alphanumeric
characters could be used in tags.  Should the alphabet for tags be based
on a whitelist or blacklist?  It would be rather hard to validate a tag
operation when there is no assumption/restriction on the alphabet.

Jed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/f06fdd3e/attachment-0001.pgp>