[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.
cworth at cworth.org
Fri Nov 27 05:41:44 PST 2009
Thanks for the patch, Jed, I almost pushed it, but noticed that it's
calling `called-interactively-p' with an argument even though that
function does not accept an argument. Meanwhile, the documentation of
called-interactively-p suggests that using (interactive "p") is an
easier way to check whether the function is called interactively.
Then, you also had one question:
On Tue, 24 Nov 2009 21:29:56 +0100, Jed Brown <jed at 59A2.org> wrote:
> It turns out that this ID has id: prefixed (which I thought was fine
> because I'm frequently doing another query with it). But git send-email
> doesn't strip that, so this was not threaded correctly. Would this be
> better with the id: prefix stripped?
No, "git send-email" wouldn't strip that since it's a custom thing for
So for passing the thread ID to notmuch users, the "id:" prefix is
convenient. For passing it not non-notmuch-based consumers it won't be
desired. And that's hard to fix.
I think long-term, a good solution would be to switch from "id:foo" to
"<foo>" as the syntax for message-ID-based search strings. That's then a
syntax that almost any consumer of a message ID should be prepared to
And that's something that will only really be possible when we bite the
bullet and write our own query parser rather than using the default
parser that Xapian provides.
More information about the notmuch