[notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file.

Jan Janak jan at ryngle.com
Wed Nov 25 13:25:01 PST 2009


Hi Bart,

On 25-11 14:55, Bart Trojanowski wrote:
> Jan,
> 
> I think your use of STRNCMP_LITERAL here is wrong...
> 
> > +	} else if (STRNCMP_LITERAL (argv[i], "--no-config-tags") == 0) {
> > +	    add_config_tags = 0;
> 
> it will happily match "--no-config-tags-xxxxxxxxxxxxxxxxxxx".

Ahh, I actually stole the code from the part which parses the --verbose
command line option. And I didn't check it. That one suffers from the same
problem, so I'll just fix them both in one patch.

> Can I also suggest including --no-config-tags in the 'notmuch help'
> output?

Sure, I'll add it.

> Besides that I am very happy with this patch series.

Thanks a lot!

  -- Jan


More information about the notmuch mailing list