[notmuch] [PATCH] Add install target for desktop files.

Carl Worth cworth at cworth.org
Sun Nov 22 20:34:53 PST 2009


On Sun, 22 Nov 2009 15:17:11 -0600, "Jeffrey C. Ollie" <jeff at ocjtech.us> wrote:
> Add an install target that uses desktop-file-install to install the
> desktop file in the appropriate location.  The location of the install
> can be modified by changing the desktop_dir variable.

Hi Jeffrey,

I suppose if we're going to have a .desktop file it only makes sense to
install it. A couple of questions:

> +install-desktop:
> +	install -d $(DESTDIR)$(desktop_dir)
> +	desktop-file-install --mode 0644 --dir $(DESTDIR)$(desktop_dir) notmuch.desktop

What does desktop-file-install do for us here? Anything that we couldn't
do with just "install"? I'm just wanting to be careful that we don't
break "make install" for people who may not even want this file.

If we really do need to install it with desktop-file-install, we could
do a configure check for that program, of course.

Thanks,

-Carl


More information about the notmuch mailing list