[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

[Dirk-Jan C. Binnema]

Hi Michiel,

>>>>> "MB" == Michiel Buddingh' <michiel at michielbuddingh.net> writes:

    MB> Dirk-Jan C. Binnema <djcb.bulk at gmail.com> wrote:
    Michiel> +
    Michiel> +static void
    Michiel> +derive_tags_from_maildir_flags (notmuch_message_t 
    Michiel> *message, const char *
    Michiel> path)
    >> 
    >> I see you don't handle the "N" -- is that deliberate? Also, a 
    >> minor addition may to also allow for '!' instead of ':' as a 
    >> separator, as that's the semi-official way to use Maildirs on 
    >> (V)FAT filesystems (which don't allow for colons in filenames).

    MB> Not deliberate.  Simply unaware of the "N" flag, nor aware of 
    MB> practices for storing Maildirs on (V)FAT.

Ah, you are right. In my code,
 http://gitorious.org/mu/mainline/blobs/master/msg/mu-msg-flags.c
I handled it because apparently some programs where using that. But I guess
it's better to stick to DJB's Maildir spec for now...

Regarding the VFAT-limitations, see eg. the Note in:
  http://docs.python.org/lib/mailbox-maildir.html
anyway, a minor point.


Best wishes,
Dirk.

-- 
Dirk-Jan C. Binnema                  Helsinki, Finland
e:djcb at djcbsoftware.nl           w:www.djcbsoftware.nl
pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C