[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

[Dirk-Jan C. Binnema]

Hi Michiel,

>>>>> "Michiel" == Michiel Buddingh' <michiel at michielbuddingh.net> writes:

    Michiel> Another thing; notmuch currently indexes by message-id (or SHA-1
    Michiel> hash if that is not present).  Maildir, on the other hand, uses
    Michiel> file names as stable (when stripped of the parts trailing the
    Michiel> colon) unique (knock on wood) identifiers.  A Maildir-aware
    Michiel> notmuch could incorporate this to be far more resistant to bulk
    Michiel> mail moves done by other clients, by using filename lookups to
    Michiel> avoid accessing and parsing the mail files themselves.

I think that is a good idea.
    
    Michiel> I should re-iterate that I'm new to notmuch, and it's obvious
    Michiel> that I'm trying to beat it into becoming something it was never
    Michiel> intended to be; on the other hand, I'd like people to chime in on
    Michiel> this.

I'm new here too, so please be gentle as I learn how things work....
    
    Michiel> +
    Michiel> +static void
    Michiel> +derive_tags_from_maildir_flags (notmuch_message_t *message, const char *
    Michiel> path)

I see you don't handle the "N" -- is that deliberate? Also, a minor addition
may to also allow for '!' instead of ':' as a separator, as that's the
semi-official way to use Maildirs on (V)FAT filesystems (which don't allow for
colons in filenames).


Best wishes,
Dirk.


-- 
Dirk-Jan C. Binnema                  Helsinki, Finland
e:djcb at djcbsoftware.nl           w:www.djcbsoftware.nl
pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C