<p><br>
On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" <<a href="mailto:dmitry.kurochkin@gmail.com">dmitry.kurochkin@gmail.com</a>> wrote:<br>
><br>
> The tag syntax check in `notmuch-tag' function was too strict and did<br>
> not allow nmbug tags with "::". Since the check is done for all<br>
> tagging operations in Emacs UI, this basically means that no nmbug<br>
> tags can be changed. The patch relaxes the tag syntax check to allow<br>
> any tag names that do not include whitespace characters.</p>
<p>Imho the syntax check should be in cli, or lib even. I posted a patch to cli some time ago when I realized it's possible to add tag "-" but you can't remove it with the current cli. (On the road, can't find the message id now.)<br>
</p>
<p>> ---<br>
> emacs/notmuch.el | 2 +-<br>
> 1 files changed, 1 insertions(+), 1 deletions(-)<br>
><br>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el<br>
> index 9813e0a..0de6123 100644<br>
> --- a/emacs/notmuch.el<br>
> +++ b/emacs/notmuch.el<br>
> @@ -555,7 +555,7 @@ notmuch-after-tag-hook will be run."<br>
> ;; Perform some validation<br>
> (when (null tags) (error "No tags given"))<br>
> (mapc (lambda (tag)<br>
> - (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)<br>
> + (unless (string-match-p "^[-+]\\S-+$" tag)<br>
> (error "Tag must be of the form `+this_tag' or `-that_tag'")))<br>
> tags)<br>
> (run-hooks 'notmuch-before-tag-hook)<br>
> --<br>
> 1.7.8.3<br>
><br>
> _______________________________________________<br>
> notmuch mailing list<br>
> <a href="mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.org</a><br>
> <a href="http://notmuchmail.org/mailman/listinfo/notmuch">http://notmuchmail.org/mailman/listinfo/notmuch</a><br>
</p>