[PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt

Daniel Kahn Gillmor dkg at fifthhorseman.net
Thu Oct 12 07:30:47 PDT 2017


On Thu 2017-10-12 08:18:15 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:
>
>>  
>> +	if (!indexopts)
>> +	    indexopts = def_indexopts = notmuch_database_get_default_indexopts (notmuch);
>> +
>
> I think I'd like parens here
>
>   indexopts = (def_indexopts = notmuch_database_get_default_indexopts (notmuch));
>
> or even split into two assignments. Others might disagree though.

I've gone with the simpler variant of splitting into two assignments.
My updated branch is still cleartext-index on
https://gitlab.com/dkg/notmuch, with commit ID
77e8c5079e854d1934e47637c15f06bbc14a4819.

Shall i push this to the mailing list as v5 of this series, or are there
more reviews coming that i should try to integrate?

     --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20171012/43c3589d/attachment.sig>


More information about the notmuch mailing list