[PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

Karl Fogel kfogel at red-bean.com
Sat Jul 5 11:18:22 PDT 2014


Sebastian Lipp <bacuh at riseup.net> writes:
>No, it happened by intention because what is "original" to you is not
>part of my freshly cloned notmuch. So I thought good practise is to
>construct *one* patch that brings the already fixed feature to the
>notmuch codebase to keep it clean.
>
>If you like better, my next patch will only base Tomis and your
>suggestions on top of the "original" patch.

Oh, I had thought the changes were already in the notmuch tree.  Now I
understand what you're saying, and yes, it makes sense.

In general, supplying a log message with the patch with avoid such
confusion.  If there is some prose expressing what the change is
supposed to to, and giving any historical context (such as the mailing
list thread starting from last year), then it will be easy for any
reviewer to understand what the patch is intended to do, and check if it
actually does that.

Best,
-Karl


More information about the notmuch mailing list