[PATCH 1/5] go: reorganize the go bindings
4winter at informatik.uni-hamburg.de
Sat May 5 04:15:35 PDT 2012
Quoting Austin Clements (2012-05-04 20:43:20)
> Quoth myself on May 04 at 2:38 pm:
> > Quoth Justus Winter on Apr 30 at 9:55 pm:
> > > Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de>
> > Whole series LGTM (and yay gofmt!). I have only two minor comments.
> > It would be nice to have a little more log message for some of these.
> > Mostly the first one could use some explanation of why you're
> > rearranging the source tree and a mention that there are no changes to
> > the files (since this is hard to get from the diff).
> > It would also be nice if this could optionally be built using the
> > libnotmuch and notmuch.h directly from the source tree containing the
> > Go bindings, rather than requiring them to be installed system-wide.
> > I don't know Go 1's build system well enough to know if there's an
> > easy way to do this.
Yes, I've been pondering that myself. There are CGO_CFLAGS and
CGO_LDFLAGS that could be used to point the c compiler to the right
paths. I'll experiment with this and propose a patch.
> Oh, also a news patch would be good, though that can obviously be
I'll send an updated patch series. Thanks for the review.
More information about the notmuch