[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

Tomi Ollila tomi.ollila at iki.fi
Sun Apr 15 10:39:12 PDT 2012


On Sun, Apr 15 2012, Mark Walters wrote:

> On Tue, 17 Jan 2012, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
>> No functional change here.  The help message previously referred to
>> the "delete" tag, but "deleted" is now preferred, so hopefully this
>> will reduce any potential confusion.
>
> This patch is trivially correct regardless of the rest of the
> series. 

Agreed. +1

>
> I think the rest of the series (which provides keybindings for
> adding/removing the delete tag to messages/threads) is worthwhile
> particularly now the exclude stuff is fairly complete (feedback at the
> time looked positive).
>
> Patch 2/3 needs simple but genuine rebasing as the names of the
> tagging functions have changed though. 

Why not :)

>
> Best wishes
>
> Mark

Tomi


>
>> ---
>>  emacs/notmuch.el |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index e4bca51..67ecd3a 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -660,12 +660,12 @@ This function advances the next thread when finished."
>>  Here is an example of how to color search results based on tags.
>>   (the following text would be placed in your ~/.emacs file):
>>  
>> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
>> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>>  						  :background \"blue\"))
>>                                     (\"unread\" . (:foreground \"green\"))))
>>  
>>  The attributes defined for matching tags are merged, with later
>> -attributes overriding earlier. A message having both \"delete\"
>> +attributes overriding earlier. A message having both \"deleted\"
>>  and \"unread\" tags with the above settings would have a green
>>  foreground and blue background."
>>    :type '(alist :key-type (string) :value-type (custom-face-edit))
>> -- 
>> 1.7.7.3
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch at notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


More information about the notmuch mailing list