[PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function

David Bremner david at tethera.net
Sun Mar 25 06:33:42 PDT 2012


On Sat, 24 Mar 2012 18:14:37 +0200, Jani Nikula <jani at nikula.org> wrote:
> Refactor to make tagging code easier to reuse in the future. No
> functional changes.

The second two look OK as well.  It isn't obvious to me that in the long
term we want an API using "file_tags" to pass in a string. It reminds me
of the term "stringly typed". Of course, I see why it is this way in an
intial refactor, but maybe something to think about before we start
propagating such an API.

d


More information about the notmuch mailing list